enzoampil / fastquant

fastquant — Backtest and optimize your ML trading strategies with only 3 lines of code!
MIT License
1.54k stars 239 forks source link

Fix pandas 425 #427

Closed skon7 closed 1 year ago

skon7 commented 1 year ago

resolves #425

Issue:

425 (AttributeError: 'DataFrame' object has no attribute 'append')

Description

This pull request addresses issue https://github.com/enzoampil/fastquant/issues/425 by replacing the append function with the concat function. The issue was caused by a compatibility problem with pandas versions greater than 2.

Changes Made:

Checklist

skon7 commented 1 year ago

the problem because ccxt library uses this api GET https://api.bithumb.com/public/ticker/ALL_BTC and this generate an error FAILED python/tests/test_fastquant.py::test_get_crypto_data - ccxt.base.errors.NetworkError: bithumb GET https://api.bithumb.com/public/ticker/ALL_BTC because of bithumb exchange.

skon7 commented 1 year ago

@enzoampil now all the apis works correctly (https://api.bithumb.com/public/ticker/ALL_BTC),all the tests in tests folder passed 9/9 and also the workflow tested in the localhost with Job succeeded. build1 build2_3

enzoampil commented 1 year ago

thanks lgtm