search

enzococca / totalopenstationToQgis

GNU General Public License v3.0
1 stars 2 forks source link

Difference between unix and windows processing #5

Closed lbartoletti closed 2 years ago

lbartoletti commented 2 years ago

Into the dialog code, there are some differences for unix and windows.

Moreover, the unix parts doesn't handle "shp" conversion.

Shall we remove the duplicated code?

lbartoletti commented 2 years ago

@enzococca This issue is not yet solved. That was not the scope of my previous PR.

One example:

https://github.com/enzococca/totalopenstationToQgis/blob/master/totalstation_dialog.py#L231 Is only for windows

And there are differences between unix and windows version for at least number 3,4

enzococca commented 2 years ago

hi @lbartoletti https://github.com/lbartoletti. I am not sure if I have understood correctly. Do you mean when try to export in pyarchinit csv format? If this is matter you need have pyarchinit plugin installed and imported in the toc the layers of pyatchinit. this function import directly the data from raw data into db of pyarchinit.

about shp, as the csv is not editable in qgis and I need to edit it to do a rototranslation between two jobs, the function exports the raw data to csv and then it converted to shapefile and imported into panel layer.

Let me know if this is matter.

best E

Il giorno lun 8 ago 2022 alle ore 06:58 Loïc Bartoletti < @.***> ha scritto:

@enzococca https://github.com/enzococca This issue is not yet solved. That was not the scope of my previous PR.

One example:

https://github.com/enzococca/totalopenstationToQgis/blob/master/totalstation_dialog.py#L231 Is only for windows

And there are differences between unix and windows version for at least number 3,4

— Reply to this email directly, view it on GitHub https://github.com/enzococca/totalopenstationToQgis/issues/5#issuecomment-1207665846, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2P5KCDK7CKLTR3VAY23F3VYCHXTANCNFSM55PBXKZA . You are receiving this because you were mentioned.Message ID: @.***>

-- Enzo Cocca PhD in "Science and Technology for Archaeology and Cultural Heritage"

ISMEO International Association of Mediterranean and Oriental Studies

mail: @.*** cell: +393495087014

lbartoletti commented 2 years ago

Nope,

At the moment I read the code and see duplicated parts and some are not the same and don't understand why.

One example out of many:

enzococca commented 2 years ago

@lbartoletti take look here https://github.com/enzococca/totalopenstationToQgis/blob/remove_duplicate/totalstation_dialog.py.

I removed duplicate code. this for windows works. let me know if works for unix.

About your question, during the develop of varius version I was concentrated just on windows and I forgot to update for unix.

thanks for your help E

enzococca commented 2 years ago

@lbartoletti can I close this issue?

lbartoletti commented 2 years ago

Not yet, I cannot try today. But, promise, I'll check this before Friday!

enzococca commented 2 years ago

Ok! Thanks

E

Il mar 9 ago 2022, 16:55 Loïc Bartoletti @.***> ha scritto:

Not yet, I cannot try today. But, promise, I'll check this before Friday!

— Reply to this email directly, view it on GitHub https://github.com/enzococca/totalopenstationToQgis/issues/5#issuecomment-1209491428, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2P5KHL42PLCNTI7NLD4VLVYJWPXANCNFSM55PBXKZA . You are receiving this because you were mentioned.Message ID: @.***>

lbartoletti commented 2 years ago

@enzococca I have a new problem now, maybe unrelated, but I cannot open a .gsi file.

QGIS freeze, it looks like an infinite loop when you try to open a .gsi file (is there a problem on the filter string?), and you click cancel.

enzococca commented 2 years ago

try now. I inserted totalopenstation-connector.cli.py instead of totalopenstation-cli_parser when you loaded the gsi

https://github.com/enzococca/totalopenstationToQgis/blob/remove_duplicate/totalstation_dialog.py#:~:text=%22totalopenstation%2Dcli%2Dparser.py%22

Il giorno ven 12 ago 2022 alle ore 09:14 Loïc Bartoletti < @.***> ha scritto:

@enzococca https://github.com/enzococca I have a new problem now, maybe unrelated, but I cannot open a .gsi file.

QGIS freeze, it looks like an infinite loop when you try to open a .gsi file (is there a problem on the filter string?), and you click cancel.

— Reply to this email directly, view it on GitHub https://github.com/enzococca/totalopenstationToQgis/issues/5#issuecomment-1212802179, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2P5KBBVRIAFYTKAFOGJQTVYX2U5ANCNFSM55PBXKZA . You are receiving this because you were mentioned.Message ID: @.***>

-- Enzo Cocca PhD in "Science and Technology for Archaeology and Cultural Heritage"

ISMEO International Association of Mediterranean and Oriental Studies

mail: @.*** cell: +393495087014

enzococca commented 2 years ago

Hi @lbartoletti can I close this issue? Have you tried?

E