search

enzoferey / ethers-error-parser

Parse Ethers.js errors with ease 💅🏻
MIT License
66 stars 8 forks source link

core: add new question about the tests to the GitHub template #45

Closed neuodev closed 1 year ago

neuodev commented 1 year ago

Please explain the main changes of your pull request

Whenever a new returned code is added, new unit tests should be written/updated to cover the new case. I added a checklist item to remind who is opening the PR to add/update the tests.

Checklist

enzoferey commented 1 year ago

Hey @AhmedIbrahim336, thanks for the PR !

Just for your information 100% test coverage is enforced via the CI, so we will not miss any tests for sure. But I'm happy to add it to the list 👍🏻

codecov-commenter commented 1 year ago

Codecov Report

Merging #45 (0a83a0f) into main (d4e452b) will not change coverage. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##              main       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          666       666           
  Branches        79        79           
=========================================
  Hits           666       666

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more