search

enzymefinance / protocol

Enzyme Protocol Implementation
https://enzyme.finance
GNU General Public License v3.0
375 stars 156 forks source link

chore: fix solhint warnings and disallow future warnings #1031

Closed fubhy closed 4 years ago

fubhy commented 4 years ago

This fixes all the warnings we have left currently.

Note the solhint-disable-line statements for non-issues e.g. the reentrancy one in SharesRequestor which is incorrectly flagging that line because of msg.sender.transfer in a different code branch (if/else statement above so not relevant)

I've also set max-warnings to 0 so that it will fail from now on if new warnings are introduced.