enzymefinance / protocol

Enzyme Protocol Implementation
https://enzyme.finance
GNU General Public License v3.0
375 stars 156 forks source link

fix: Makefile error :79 [unexpected token] fixed #1055

Closed milaabl closed 1 year ago

milaabl commented 1 year ago

This line fixes the make build error for me in a Command prompt:

OS: Windows 11

Generating interfaces ...
)nvalid line format in tests/interfaces/interfaces.txt (
make: *** [Makefile:79: tests/interfaces/internal/] Error 1
fubhy commented 1 year ago

Hi. Thanks for the PR. This fix should not be necessary (and is also not corect because the / is required to explicitly identify the path as a directory). What version of make are you using if I may ask?

milaabl commented 1 year ago

@fubhy Ah, got it, thank you! I'm using Make 4.4.1

fubhy commented 1 year ago

I think I can fix that by instead using a sentinel file. Let me try ...

fubhy commented 1 year ago

This should fix it: https://github.com/enzymefinance/protocol/commit/d91720e4140bb623327df150be9096ebff59ae7a

milaabl commented 1 year ago

Hmm, Sentinel didn't fix that for me for some reason

fubhy commented 1 year ago

Hmm but it doesn't have the / at the end anymore.

fubhy commented 1 year ago

The error also sounds like it's an issue with interfaces.txt and not the Makefile

fubhy commented 1 year ago

https://github.com/enzymefinance/protocol/blob/d91720e4140bb623327df150be9096ebff59ae7a/Makefile#L94-L100

milaabl commented 1 year ago

@fubhy yeah, that's indeed strange, might be something with file encodings on my end maybe. OK, thank you anyways!! I'll just keep the update that makes it works for me on my local end then.

fubhy commented 1 year ago

@fubhy yeah, that's indeed strange, might be something with file encodings on my end maybe. OK, thank you anyways!! I'll just keep the update that makes it works for me on my local end then.

The problem is that your change merely disables a part of the make file by breaking the reference to the interfaces build step. It is not fixing it but merely short circuiting it heh