Closed luongnt95 closed 4 years ago
@luongnt95 Actually, I think we should structure these functions slightly differently, to protect against bad / accidental inputs.
__redeemShares(uint256 _sharesQuantity, bool _bypassFailure) private
redeemSharesQuantity()
redeemShares() external
__redeemShares(totalShares, false)
redeemSharesQuantity(uint256 _sharesQuantity) external
__redeemShares(_sharesQuantity, false)
redeemSharesEmergency() external
Most of the comments in the previous review are still valid (I will close the ones that are not).
@luongnt95 Actually, I think we should structure these functions slightly differently, to protect against bad / accidental inputs.
__redeemShares(uint256 _sharesQuantity, bool _bypassFailure) private- basically the currentredeemSharesQuantity()redeemShares() external- calls__redeemShares(totalShares, false)redeemSharesQuantity(uint256 _sharesQuantity) external- calls__redeemShares(_sharesQuantity, false)redeemSharesEmergency() external- calls__redeemShares(totalShares, false)Most of the comments in the previous review are still valid (I will close the ones that are not).