search

enzymejs / chai-enzyme

Chai.js assertions and convenience functions for testing React Components with enzyme
MIT License
787 stars 72 forks source link

Publish latest version #178

Closed sugarshin closed 7 years ago

sugarshin commented 7 years ago

HI,

Available this warning when npm installation.

warning "chai-enzyme@0.7.0" has unmet peer dependency "react-addons-test-utils@^0.14.0 || ^15.0.0-0".

Please latest version publish to npm .

ayrton commented 7 years ago

Related PR https://github.com/producthunt/chai-enzyme/pull/166

I think you now have to specify react-addons-test-utils as a dev dependency

ljharb commented 7 years ago

Yes, this is intended, since it's a requirement of enzyme's.

ayrton commented 7 years ago

@ljharb do we have to revert #166 or is everything all good right now?

ljharb commented 7 years ago

I don't see why; the only way someone could run into this is if they were not explicitly depending on things enzyme requires. This is a bug fix.

sugarshin commented 7 years ago

I mean master branch and latest version published to npm are different.

ljharb commented 7 years ago

v0.7.0 was released 2 days ago; https://github.com/producthunt/chai-enzyme/commit/3081e30e7346671b458a2a3bef8c4e468b535288 is the only commit not yet released.

Another publish of v0.7.1 would be fine, sure.

ayrton commented 7 years ago

Released 0.7.1 just now