search

enzymejs / chai-enzyme

Chai.js assertions and convenience functions for testing React Components with enzyme
MIT License
787 stars 72 forks source link

Fix to allow React 17 #232

Closed SailingSteve closed 3 years ago

SailingSteve commented 3 years ago

Initial checkin to support React 17

ljharb commented 3 years ago

React 17 support is blocked on there being an official react 17 enzyme adapter.

perrin4869 commented 2 years ago

hm... recent npm versions fail to install without the --legacy-peer-deps flag or --force flag I've been using chai-enzyme just fine with v17 and the unofficial adapter by wojtekmaj... Even without the official adapter, I think support for react 17 isn't realistically going to need changes in this module?

ljharb commented 2 years ago

@perrin4869 it needs this module to test on react 17.

perrin4869 commented 2 years ago

Would it be acceptable to test using the unofficial module for now?

ljharb commented 2 years ago

No; if the unofficial adapter passed tests, there'd be an official adapter.

perrin4869 commented 2 years ago

Well, in this case it would just need to be good enough to pass the tests in this repo though right?