search

enzymejs / enzyme-matchers

Jasmine/Jest assertions for enzyme
MIT License
892 stars 116 forks source link

upgrade jest-environment-jsdom to 24 to resolve braces security advisory #299

Closed tgaff closed 5 years ago

tgaff commented 5 years ago

See #295 (and #296 #297 ) Root Yarn.lock also updated which I think was missed in #297. (Feel free to credit one of the other users on that.)

Note: I noticed the older version of braces still shows in an individual package yarn.lock file. I don't have any experience with lerna but I tried to figure out how lerna uses those and I think the answer is that it doesn't. Those files look like they haven't been updated since their creation. I'm opening another PR to remove them.

blainekasten commented 5 years ago

Thanks @tgaff !

tgaff commented 5 years ago

Thanks! Do you think you'll do a release for this soon?
I think people looking for it are all just trying to get past an automated security alert. This was the last package in one of our repos that I was unable to just upgrade outright.

blainekasten commented 5 years ago

@tgaff sorry, i've been very busy lately. I will get this done this week. Maybe today, likely tomorrow

tgaff commented 5 years ago

thanks a ton!

blainekasten commented 5 years ago

7.0.2 is releases with a fix!

tgaff commented 5 years ago

Thanks!