search

enzymejs / enzyme-matchers

Jasmine/Jest assertions for enzyme
MIT License
892 stars 116 forks source link

Upgrade Babel to 7.6.2 and Jest to 24.9.0 #315

Closed vkrol closed 4 years ago

vkrol commented 4 years ago

https://github.com/FormidableLabs/enzyme-matchers/pull/313#issuecomment-538447718

What do you think about updating jest in the repo

The latest version of Jest doesn't support Babel 6. That's why I upgraded the Babel at the same time.

I had to recreate the PR because I mistakenly removed the repository.

blainekasten commented 4 years ago

@vkrol This is awesome! Super impressive job adding all of these comments to help me understand the review :) REALLY REALLY APPRECIATE YOU!

vkrol commented 4 years ago

@blainekasten you are welcome! Thanks! 😀

vkrol commented 4 years ago

@blainekasten I will do it:

implementing this change to verify that it all works correctly still?

https://github.com/FormidableLabs/enzyme-matchers/pull/313#issuecomment-538447718 in a few days.