search

enzymejs / enzyme-matchers

Jasmine/Jest assertions for enzyme
MIT License
892 stars 116 forks source link

Upgrade Jest to v25 #339

Closed Methuselah96 closed 4 years ago

Methuselah96 commented 4 years ago

Resolves https://github.com/FormidableLabs/enzyme-matchers/issues/334. Reopens https://github.com/FormidableLabs/enzyme-matchers/pull/335.

GreenGremlin commented 3 years ago

Can the version pin for jest-environment-jsdom be more open? It looks like it's only used in one place and a more loose version pin would allow jest-enzyme to be compatible with more versions of jest. As it currently stands, the dependecy on jest-environment-jsdom ends up pulling in pretty much the full jest dependency tree, which is not good if the consuming package is not on the same major version of jest. I just tried setting up jest-enzyme in a package running jest 26 and ended up with a bunch of jest 24 packages. I'm now getting typescript errors for jest being undefined, which I assume is caused by incompatible versions of jest being installed.

Methuselah96 commented 3 years ago

@GreenGremlin Yeah, agreed. I made https://github.com/FormidableLabs/enzyme-matchers/pull/343 to address this, but it looks the maintainers are missing in action.

csvan commented 3 years ago

@blainekasten seems like this needs to be published