search

enzymejs / enzyme-matchers

Jasmine/Jest assertions for enzyme
MIT License
892 stars 116 forks source link

Transfer to the enzymejs org? #340

Closed ljharb closed 3 years ago

ljharb commented 4 years ago

Hi!

Now that enzyme is in its own org - https://github.com/enzymejs - do you have any interest in transfering this repo/npm package to it? You'd of course continue to maintain it the same, but it'd make it more discoverable and supported :-).

If you're interested, please lmk what github and npm names to add to the orgs!

blainekasten commented 4 years ago

Hey @ljharb!

I don't actually work for Formidable anymore. So it's not really my call. It would be up to @boygirl. I'm content with either approach. This library get's used a lot so I don't think it's necessary.

To me, it's actually nice letting Formidable own it, because then I'm not the only one maintaining this! (which I've been doing less of lately anyhow)

ljharb commented 4 years ago

Totally fair :-) my hope would be that more people could maintain it if it were transferred (since Formidable wouldn't have to be the only bottleneck there), and that Formidable would continue maintaining it as well!

ljharb commented 4 years ago

ping @boygirl; any thoughts on this? There's a number of unmerged PRs, for example.

Methuselah96 commented 3 years ago

@boygirl Can you help us out here? Seems like this project has stalled.

boygirl commented 3 years ago

@ljharb apologies for the long delay. I got approval to transfer this project to the enzyme github org if you're still interested in taking it over. Let me know, and I can help with the npm transfer as well.

ljharb commented 3 years ago

@boygirl awesome, I'm very interested!

I've added you to the enzymejs github org, and if you npm owner add ljharb, i can add it (and you) to the enzyme npm org as well. Thank you!

boygirl commented 3 years ago

@ljharb you should be good to go. Let me know if you need anything else.

ljharb commented 3 years ago

@boygirl thanks! Looks like i still need npm publish rights. I invited @blainekasten to the enzyme npm org; what's your npm username?

boygirl commented 3 years ago

Hmm, you should have publish rights. My npm username is boygirl, but that user isn't an owner on these packages. Only formidable-owner and blainekasten. I logged in as formidable-owner via npm's web interface and invited you. Let me triple check. I've have had some issues with updating npm permissions via the web interface before.

boygirl commented 3 years ago

Okay, I've added you via the CLI, so you should now have publish rights for enzyme-matchers, jest-enzyme, and jasmine-enzyme. I couldn't add you to eslint-config-jest-enzyme or jest-environment-enzyme because @blainekasten is the sole owner.

ljharb commented 3 years ago

Awesome, thanks! Let me know if you lost any access you need in the process, but I think we should be all set.