search

enzymejs / enzyme-matchers

Jasmine/Jest assertions for enzyme
MIT License
892 stars 116 forks source link

Add jest-environment-jsdom to peer deps #346

Open Whoaa512 opened 4 years ago

Whoaa512 commented 4 years ago

This is blocking a jest upgrade we're doing, since multiple copies of the jest-environment-jsdom is producing errors in our tests.

The other PR(https://github.com/FormidableLabs/enzyme-matchers/pull/343) for this seems stalled out.

ljharb commented 4 years ago

There's no need to submit a duplicate PR; #343 or #344 will be the one that's landed imo.

ljharb commented 2 years ago

@Whoaa512 would you please restore the branch? i need to keep both PRs open and in sync to avoid polluting the repo with the PR ref.

Whoaa512 commented 2 years ago

This is a duplicate as you've said. I'm trying to close out stale PRs that have seen no movement and this seems superseded by the 2 other PRs linked

ljharb commented 2 years ago

Yes, but the PR ref will remain as a permanent mark on the repo, whereas if this PR can be left open, then I can update all three PRs to the same sha and land them all at once, later.