enzymejs / enzyme

JavaScript Testing utilities for React
https://enzymejs.github.io/enzyme/
MIT License
19.95k stars 2.01k forks source link

Support for React 17 #2429

Open layershifter opened 4 years ago

layershifter commented 4 years ago

An RC for React 17 was released: https://reactjs.org/blog/2020/08/10/react-v17-rc.html

And it does not work with React 17, oops: image

Working on an isolated repro ✍️

aaryn101 commented 1 year ago

@VictorQueiroz no, and don't contradict a maintainer.

Right? How dare he contradict a maintainer?!

ljharb commented 1 year ago

@aaryn101 about whether the project is maintained? yes, that's right, since only maintainers get a say on that.

sbaechler commented 1 year ago

I think what @JWBrownie was meant to ask was if Enzyme will be supporting React 17 and 18. We can expect this will never be the case. So even if the project is still maintained, it won't work with current and feature versions of React.

hoangph271 commented 1 year ago

I think what @JWBrownie was meant to ask was if Enzyme will be supporting React 17 and 18. We can expect this will never be the case. So even if the project is still maintained, it won't work with current and feature versions of React.

thanks for your answer may I ask why this won't be the case?

ljharb commented 1 year ago

@sbaechler it will indeed eventually be the case, and your expectation is incorrect.

VictorQueiroz commented 1 year ago

This thread is complete madness.

aaryn101 commented 1 year ago

@aaryn101 about whether the project is maintained? yes, that's right, since only maintainers get a say on that.

From the perspective of anyone else, it is quite dead: no new publishes to npm for 4 years, no support for React 17 (much less 18), no meaningful changes to the repo for at least 6 months.

At this point, anyone who had plans to move past React 16 has likely long since moved off of enzyme. I thank the maintainers for their work but from the perspective of someone who has once used this library and been forced to move on, it is dead.

ljharb commented 1 year ago

@aaryn101 the react 16 adapter was published 8 months ago, it's just that enzyme core hasn't had a publish in that long.

You can choose what you use, but something isn't "dead" merely because you've decided it.