search

enzymejs / enzyme

JavaScript Testing utilities for React
https://enzymejs.github.io/enzyme/
MIT License
19.95k stars 2.01k forks source link

Improve README remove duplicated parentheses #2447

Closed OtacilioN closed 4 years ago

OtacilioN commented 4 years ago

Is there a particular reason for using duplicate parentheses in the documentation? Or it is just a minor typo?

OtacilioN commented 4 years ago

I don't know if I got the reason about using duplicated parentheses, but it can be a little bit confusing, specially to beginners.

That's no possibly to maintain the trailing coma and also remove the internal parentheses?

ljharb commented 4 years ago

Not without violating the lint rules.

OtacilioN commented 4 years ago

Okay got it, sorry for the pull request, to me this duplicated parentheses was very confusing.

Since it's intentional, can I close the PR? Or can we change de lint rule?

ljharb commented 4 years ago

You'd have to change the rule inside eslint core itself first (which would be great). I think the PR can be closed, yes.