search

enzymejs / enzyme

JavaScript Testing utilities for React
https://enzymejs.github.io/enzyme/
MIT License
19.95k stars 2.01k forks source link

add enzyme-adapter-react-17 (no TODO tags) #2534

Open createthis opened 3 years ago

createthis commented 3 years ago

Same as https://github.com/enzymejs/enzyme/pull/2430 with TODO_17 tags removed.

How working on this PR made me feel: derpy_dog

codecov[bot] commented 3 years ago

Codecov Report

Merging #2534 (46d0422) into master (8c55734) will decrease coverage by 0.48%. The diff coverage is 92.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2534      +/-   ##
==========================================
- Coverage   96.31%   95.83%   -0.49%     
==========================================
  Files          49       53       +4     
  Lines        4207     4749     +542     
  Branches     1130     1304     +174     
==========================================
+ Hits         4052     4551     +499     
- Misses        155      198      +43
Impacted Files Coverage Δ
packages/enzyme-adapter-utils/src/Utils.js 96.26% <ø> (ø)
...pter-react-17/src/findCurrentFiberUsingSlowPath.js 68.42% <68.42%> (ø)
...ges/enzyme-adapter-react-17/src/detectFiberTags.js 85.24% <85.24%> (ø)
...zyme-adapter-react-17/src/ReactSeventeenAdapter.js 96.11% <96.11%> (ø)
packages/enzyme-adapter-react-17/src/index.js 100.00% <100.00%> (ø)
...pter-react-helper/src/getAdapterForReactVersion.js 100.00% <100.00%> (ø)
packages/enzyme/src/ShallowWrapper.js 99.13% <100.00%> (+0.01%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c55734...46d0422. Read the comment docs.

leopucci commented 3 years ago

Seems to be an unoficial adapter for 17 here: https://www.npmjs.com/package/@wojtekmaj/enzyme-adapter-react-17 image

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: projectname@undefined
npm ERR! Found: react@17.0.2
npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.0.0-0" from enzyme-adapter-react-16@1.15.6
npm ERR! node_modules/enzyme-adapter-react-16
npm ERR!   dev enzyme-adapter-react-16@"^1.15.6" from the root project
luiscosio commented 3 years ago

Bumping this issue, is it mergeable? We need React 17 support.

EricKwan2014 commented 2 years ago

happy new year everyone, may I know what is the roadmap/plans to includes this PR?

ljharb commented 2 years ago

@EricKwan2014 the plan is to include it. there is no date/deadline.

shiraze commented 2 years ago

Hi guys, is this the correct place to ask what support my team and I can give to get a React 17 adaptor over the line? We've considered React-Testing-Library but the overhead of converting tests is so much that it might make better sense for us to provide support here.

ljharb commented 2 years ago

@shiraze yes, if you can provide people and time, i'd be happy to set up a call to get everyone on the same page so we can get things landed.

shiraze commented 2 years ago

@ljharb excellent. Let's set up a call

ljharb commented 2 years ago

@shiraze please reach out on twitter DMs or at gmail

mak12 commented 2 years ago

Any update on this?

shiraze commented 2 years ago

Unfortunately I wasn't able to provide people and time