search

enzymejs / enzyme

JavaScript Testing utilities for React
https://enzymejs.github.io/enzyme/
MIT License
19.96k stars 2.01k forks source link

Projectname #43

Closed hkjels closed 8 years ago

hkjels commented 8 years ago

This can be confused with the ClojureScript view-layer over React called Reagent. It should be mentioned in the Readme.

sundbry commented 8 years ago

Please don't lift the reagent name from the clojurescript project. It is a great library. A couple name suggestions: "Retest" "Replay"

rygine commented 8 years ago

Not sure how this slipped past the author(s). I'm also in favor of a name change.

spikebrehm commented 8 years ago

Not sure how this slipped past the author(s).

It's unrealistic for a few people to be familiar with the full breadth of the React ecosystem. The npm package name was free so we figured so was the name.

spikebrehm commented 8 years ago

Locking this issue for now because everyone agrees we need a rename. Thanks again to everybody for your input.

Please follow along on #46 for naming suggestions.

ljharb commented 8 years ago

Closed with 38ae4b2

ljharb commented 8 years ago

Thanks everyone for your feedback and civil discussion, and thanks to those who agreed with the rename but refrained from burying us in +1s! We've renamed the project to enzyme and it's freshly available on npm. Thanks as well to those who suggested names in #46.

Mistakes happen, but we definitely don't want to steal someone's thunder, nor steamroll another project, nor add confusion to the plates of those attempting to build cool stuff. Our sincere apologies to the folks at https://github.com/reagent-project/reagent (and its users).

We've published a "v1.0.1" under the "reagent" name on npm that does nothing except direct users to install enzyme - we'll leave that package up for at least a month or two, after which, @reagent-project is free to take it over if they wish; otherwise we'll keep it as-is so as to not leave it open for someone else to accidentally take.

gadfly361 commented 8 years ago

Very excited and grateful to see this name change, thank you!!

@ljharb Definitely makes sense to leave the "reagent" name up on npm for a couple of months as a pointer to enzyme to ease the transition. After that, I am happy to take it over on behalf of reagent-project. We can coordinate that when the time comes and outside of this thread (my email is on my github page).

Morantron commented 8 years ago

:clap: