states instead of files

h1alexbel commented 1 year ago

closes #32

@l3r8yJ take a look, please

PR-Codex overview

Detailed summary

Updated XML structure in master.xml file to include states and change states.
Added State interface in State.java.
Renamed Ids class to Sha in Sha.java.
Updated Names and Authors classes to retrieve file names and authors based on state ID.
Added new test classes for Author, Sha, and StateChanges.
Updated Master class to use new Names constructor.

The following files were skipped due to too many changes: src/main/java/io/github/eocqrs/cmig/sha/Sha.java, src/main/java/io/github/eocqrs/cmig/sha/StateChanges.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

zoeself commented 1 year ago

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 94.11% and project coverage change: +21.99% :tada:

Comparison is base (2dab3be) 30.50% compared to head (d516b03) 52.50%. Report is 11 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #34 +/- ## ============================================= + Coverage 30.50% 52.50% +21.99% - Complexity 8 11 +3 ============================================= Files 6 7 +1 Lines 59 80 +21 Branches 0 1 +1 ============================================= + Hits 18 42 +24 + Misses 41 38 -3 ``` | [Files Changed](https://app.codecov.io/gh/eo-cqrs/cmig/pull/34?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs) | Coverage Δ | | |---|---|---| | [src/main/java/io/github/eocqrs/cmig/Master.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/34?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvTWFzdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...c/main/java/io/github/eocqrs/cmig/meta/Author.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/34?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvbWV0YS9BdXRob3IuamF2YQ==) | `100.00% <100.00%> (ø)` | | | [...rc/main/java/io/github/eocqrs/cmig/meta/Names.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/34?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvbWV0YS9OYW1lcy5qYXZh) | `100.00% <100.00%> (+42.85%)` | :arrow_up: | | [src/main/java/io/github/eocqrs/cmig/sha/Sha.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/34?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvc2hhL1NoYS5qYXZh) | `100.00% <100.00%> (ø)` | | | [...n/java/io/github/eocqrs/cmig/sha/StateChanges.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/34?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvc2hhL1N0YXRlQ2hhbmdlcy5qYXZh) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zoeself commented 1 year ago

@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is 2023-08-14T09:09:06.991792.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

h1alexbel commented 1 year ago

@zoeself deregister

zoeself commented 1 year ago

@zoeself deregister

@h1alexbel ok, I've removed this task from scope. I'm not managing it anymore.

h1alexbel commented 1 year ago

@zoeself register

zoeself commented 1 year ago

@zoeself register

@h1alexbel I've just registered this ticket as a task and will assign it to someone soon. Thanks!

zoeself commented 1 year ago

@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is 2023-08-14T09:19:05.633557.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

h1alexbel commented 1 year ago

@l3r8yJ master code a bit take a look again, please

h1alexbel commented 1 year ago

@l3r8yJ

h1alexbel commented 1 year ago

@rultor merge

rultor commented 1 year ago

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 1 year ago

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 2min)

zoeself commented 1 year ago

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.

eo-cqrs / cmig