eo-cqrs / cmig

Apache Cassandra Schema Migration
MIT License
5 stars 2 forks source link

refactor #40

Closed l3r8yJ closed 1 year ago

l3r8yJ commented 1 year ago

@h1alexbel take a look, please

wdyt?


PR-Codex overview

Focus of this PR:

This PR focuses on making various changes and improvements to the codebase.

Detailed summary:

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

zoeself commented 1 year ago

@l3r8yJ thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

zoeself commented 1 year ago

@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is 2023-08-17T07:49:05.846396.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 80.00% and project coverage change: -1.69% :warning:

Comparison is base (afadd6f) 65.43% compared to head (cbbd100) 63.75%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #40 +/- ## ============================================ - Coverage 65.43% 63.75% -1.69% Complexity 15 15 ============================================ Files 7 7 Lines 81 80 -1 Branches 1 0 -1 ============================================ - Hits 53 51 -2 - Misses 28 29 +1 ``` | [Files Changed](https://app.codecov.io/gh/eo-cqrs/cmig/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs) | Coverage Δ | | |---|---|---| | [...c/main/java/io/github/eocqrs/cmig/meta/Author.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvbWV0YS9BdXRob3IuamF2YQ==) | `100.00% <ø> (ø)` | | | [...rc/main/java/io/github/eocqrs/cmig/meta/Names.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvbWV0YS9OYW1lcy5qYXZh) | `100.00% <ø> (ø)` | | | [...ain/java/io/github/eocqrs/cmig/session/InFile.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvc2Vzc2lvbi9JbkZpbGUuamF2YQ==) | `50.00% <0.00%> (ø)` | | | [...ain/java/io/github/eocqrs/cmig/session/Simple.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvc2Vzc2lvbi9TaW1wbGUuamF2YQ==) | `50.00% <ø> (ø)` | | | [src/main/java/io/github/eocqrs/cmig/sha/Sha.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvc2hhL1NoYS5qYXZh) | `100.00% <ø> (ø)` | | | [...n/java/io/github/eocqrs/cmig/sha/StateChanges.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvc2hhL1N0YXRlQ2hhbmdlcy5qYXZh) | `92.30% <88.88%> (-7.70%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

h1alexbel commented 1 year ago

@l3r8yJ let's integrate it in the master branch right after #42

h1alexbel commented 1 year ago

@l3r8yJ can you resolve the conflict and we are good to go

l3r8yJ commented 1 year ago

@h1alexbel sure, bit later

zoeself commented 1 year ago

@h1alexbel Don't forget to close this ticket before the deadline (2023-08-17T07:49:06). You are past the first half of the allowed period.

zoeself commented 1 year ago

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.