eo-cqrs / cmig

Apache Cassandra Schema Migration
MIT License
5 stars 2 forks source link

ids #54

Closed l3r8yJ closed 1 year ago

l3r8yJ commented 1 year ago

closes #53

@h1alexbel take a look, please


PR-Codex overview

This PR adds the Ids class to retrieve the IDs of change states from an XML document. It also includes a corresponding test case.

Detailed summary

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

zoeself commented 1 year ago

@l3r8yJ thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.72% :tada:

Comparison is base (cff0808) 63.75% compared to head (778ff22) 65.47%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #54 +/- ## ============================================ + Coverage 63.75% 65.47% +1.72% - Complexity 15 17 +2 ============================================ Files 7 8 +1 Lines 80 84 +4 ============================================ + Hits 51 55 +4 Misses 29 29 ``` | [Files Changed](https://app.codecov.io/gh/eo-cqrs/cmig/pull/54?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs) | Coverage Δ | | |---|---|---| | [...rc/main/java/io/github/eocqrs/cmig/meta/Names.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/54?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvbWV0YS9OYW1lcy5qYXZh) | `100.00% <ø> (ø)` | | | [src/main/java/io/github/eocqrs/cmig/meta/Ids.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/54?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvbWV0YS9JZHMuamF2YQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zoeself commented 1 year ago

@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is 2023-08-19T18:49:04.503284.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

h1alexbel commented 1 year ago

@rultor merge

rultor commented 1 year ago

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

h1alexbel commented 1 year ago

@l3r8yJ thanks

rultor commented 1 year ago

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 2min)

zoeself commented 1 year ago

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.