eo-cqrs / cmig

Apache Cassandra Schema Migration
MIT License
5 stars 2 forks source link

prepared keyspace and table for CMIG checks #56

Closed h1alexbel closed 1 year ago

h1alexbel commented 1 year ago

@l3r8yJ take a look, please closes #55


PR-Codex overview

This PR focuses on making changes to the codebase related to the Cmig session, Sha, StateChanges, InText, and check packages.

Detailed summary

The following files were skipped due to too many changes: src/test/java/io/github/eocqrs/cmig/session/InTextTest.java, src/test/java/it/CmigKeyspaceIT.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

zoeself commented 1 year ago

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 76.47% and project coverage change: +0.85% :tada:

Comparison is base (a55f792) 67.41% compared to head (4325ed7) 68.26%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #56 +/- ## ============================================ + Coverage 67.41% 68.26% +0.85% - Complexity 19 24 +5 ============================================ Files 9 12 +3 Lines 89 104 +15 ============================================ + Hits 60 71 +11 - Misses 29 33 +4 ``` | [Files Changed](https://app.codecov.io/gh/eo-cqrs/cmig/pull/56?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs) | Coverage Δ | | |---|---|---| | [src/main/java/io/github/eocqrs/cmig/sha/Sha.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/56?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvc2hhL1NoYS5qYXZh) | `90.90% <0.00%> (-9.10%)` | :arrow_down: | | [...ain/java/io/github/eocqrs/cmig/session/InText.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/56?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvc2Vzc2lvbi9JblRleHQuamF2YQ==) | `57.14% <57.14%> (ø)` | | | [...java/io/github/eocqrs/cmig/check/CmigKeyspace.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/56?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvY2hlY2svQ21pZ0tleXNwYWNlLmphdmE=) | `100.00% <100.00%> (ø)` | | | [.../java/io/github/eocqrs/cmig/check/StatesTable.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/56?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvY2hlY2svU3RhdGVzVGFibGUuamF2YQ==) | `100.00% <100.00%> (ø)` | | | [...n/java/io/github/eocqrs/cmig/sha/StateChanges.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/56?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvc2hhL1N0YXRlQ2hhbmdlcy5qYXZh) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zoeself commented 1 year ago

@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is 2023-08-21T09:09:07.526226.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

h1alexbel commented 1 year ago

@rultor merge

h1alexbel commented 1 year ago

@rultor merge

rultor commented 1 year ago

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 1 year ago

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 2min)

rultor commented 1 year ago

@rultor merge

@h1alexbel The pull request is closed already, so I can't merge it

rultor commented 1 year ago

@rultor merge

@h1alexbel I'm sorry, I don't understand you :( Check this page and try again please

zoeself commented 1 year ago

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.