eo-cqrs / cmig

Apache Cassandra Schema Migration
MIT License
5 stars 2 forks source link

CMIG default dir, master `0.0.1` #61

Closed h1alexbel closed 1 year ago

h1alexbel commented 1 year ago

@l3r8yJ take a look, please closes #60


PR-Codex overview

This PR focuses on improving the code quality and functionality of the migration tool.

Detailed summary

The following files were skipped due to too many changes: src/main/java/io/github/eocqrs/cmig/Preload.java, src/test/java/it/MasterIT.java, src/main/java/io/github/eocqrs/cmig/Master.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

zoeself commented 1 year ago

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

zoeself commented 1 year ago

@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is 2023-08-24T07:49:05.843425.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

h1alexbel commented 1 year ago

@zoeself deregister

zoeself commented 1 year ago

@zoeself deregister

@h1alexbel ok, I've removed this task from scope. I'm not managing it anymore.

h1alexbel commented 1 year ago

@zoeself register

zoeself commented 1 year ago

@zoeself register

@h1alexbel I've just registered this ticket as a task and will assign it to someone soon. Thanks!

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 28.20% and project coverage change: -3.23% :warning:

Comparison is base (4325ed7) 68.26% compared to head (5946f9c) 65.04%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #61 +/- ## ============================================ - Coverage 68.26% 65.04% -3.23% - Complexity 24 27 +3 ============================================ Files 12 13 +1 Lines 104 123 +19 ============================================ + Hits 71 80 +9 - Misses 33 43 +10 ``` | [Files Changed](https://app.codecov.io/gh/eo-cqrs/cmig/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs) | Coverage Δ | | |---|---|---| | [...ain/java/io/github/eocqrs/cmig/session/InText.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvc2Vzc2lvbi9JblRleHQuamF2YQ==) | `50.00% <0.00%> (-7.15%)` | :arrow_down: | | [...ain/java/io/github/eocqrs/cmig/sha/ContentsOf.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvc2hhL0NvbnRlbnRzT2YuamF2YQ==) | `87.50% <ø> (-1.39%)` | :arrow_down: | | [src/main/java/io/github/eocqrs/cmig/sha/Sha.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvc2hhL1NoYS5qYXZh) | `90.00% <ø> (-0.91%)` | :arrow_down: | | [src/main/java/io/github/eocqrs/cmig/Master.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvTWFzdGVyLmphdmE=) | `24.13% <8.33%> (+24.13%)` | :arrow_up: | | [src/main/java/io/github/eocqrs/cmig/Preload.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvUHJlbG9hZC5qYXZh) | `50.00% <50.00%> (ø)` | | | [...java/io/github/eocqrs/cmig/check/CmigKeyspace.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvY2hlY2svQ21pZ0tleXNwYWNlLmphdmE=) | `100.00% <100.00%> (ø)` | | | [.../java/io/github/eocqrs/cmig/check/StatesTable.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvY2hlY2svU3RhdGVzVGFibGUuamF2YQ==) | `100.00% <100.00%> (ø)` | | | [...n/java/io/github/eocqrs/cmig/sha/StateChanges.java](https://app.codecov.io/gh/eo-cqrs/cmig/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eo-cqrs#diff-c3JjL21haW4vamF2YS9pby9naXRodWIvZW9jcXJzL2NtaWcvc2hhL1N0YXRlQ2hhbmdlcy5qYXZh) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zoeself commented 1 year ago

@l3r8yJ please review this Pull Request. Deadline (when it should be merged or closed) is 2023-08-24T07:59:11.068559.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

h1alexbel commented 1 year ago

@l3r8yJ take a look again, please

l3r8yJ commented 1 year ago

@h1alexbel looks good to me!

zoeself commented 1 year ago

@l3r8yJ thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.