search

eo-cqrs / eokson

Elegant, Object-Oriented JSON Manipulations
https://eo-cqrs.github.io/eokson
MIT License
5 stars 0 forks source link

enable jtcop #45

Closed h1alexbel closed 1 year ago

h1alexbel commented 1 year ago

closes #9

PR-Codex overview

This PR focuses on updating a test method name and adding a Maven plugin.

Detailed summary

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

zoeself commented 1 year ago

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (f6529f3) 94.96% compared to head (ce9792e) 94.96%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #45 +/- ## ========================================= Coverage 94.96% 94.96% Complexity 84 84 ========================================= Files 11 11 Lines 159 159 Branches 3 3 ========================================= Hits 151 151 Misses 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

zoeself commented 1 year ago

@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is 2023-07-07T11:19:05.758066.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

h1alexbel commented 1 year ago

@rultor merge

rultor commented 1 year ago

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 1 year ago

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 2min)

zoeself commented 1 year ago

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.