eodash / eodash

MIT License
0 stars 0 forks source link

Compare indicator functionality #75

Closed santilland closed 1 month ago

santilland commented 1 month ago

This branch brings the capability to compare any two indicators. The initial proof of concepts looks quite good. It is possible to enable/disable it by adding enableComparison in the properties for the EodashMap and EodashItemFilter widgets (defaults to false).

There are issues with keeping sync between maps when switching projection, it also seems that in general widgets might load before required things are finished loading and the interaction breaks. I think this is not related to the compare function in itself.

I would propose to merge this sooner rather then later, so that potential new implementation can be tested / developed with this functionality in mind.

In principle i would think following is missing (but not blocking)

image

santilland commented 1 month ago

So, with the comparison disabled in configuration i would propose to merge this into our main branch, so that it does not diverge with other developments. It maintains the original functionality and will allow us to better explore the integration with map projections as it will affect the main and comparison map.

santilland commented 1 month ago

Great, thanks! I will delete the branch