search

eodms-sgdot / py-eodms-rapi

EODMS RAPI Client is a Python3 package used to access the REST API service provided by the Earth Observation Data Management System (EODMS) from Natural Resources Canada.
Other
13 stars 4 forks source link

Network interruption causes downloading to fail and not recover #20

Closed peanutbutter-memory closed 2 years ago

peanutbutter-memory commented 2 years ago

Network interruption when downloading causes Python API to fail. The order is still processed and sent to my email to download via other means.

Queries/Thoughts:

  1. Perhaps I should be only passing one productID at a time instead of filtered search and check for failure? Through it would be great if the downloader would recover from network interruptions i.e. I disconnect from vpn.
  2. If the downloading can not recover, then the order should be cancelled. I mistakenly restarted the script and had two identical orders waiting in my email. I do not want to consume more resources than necessary from the system.

Thanks so much for this API!

2022-02-18-eodms-python-api-does-not-handle-network-issues

keballantyne commented 2 years ago

This issue originated in eodms-cli, however it has also been transferred to the py-eodms-rapi repository since the fix will be made in the py-eodms-rapi Python package.

keballantyne commented 2 years ago

Issue has been fixed with v1.5.2 https://github.com/eodms-sgdot/py-eodms-rapi/commit/8398a492c93d1df6f60964965b37776d9241b659