eoger / tabcenter-redux

Vertical Tabs extension for Firefox
Mozilla Public License 2.0
379 stars 67 forks source link

Hardcoded hsl format #245

Closed noscript closed 6 years ago

noscript commented 6 years ago

Is there any reason why it is done that way:

--tab-background-normal: 0, 0%, 99%;
...
background-color: hsl(var(--tab-background-normal));

instead of:

--tab-background-normal: hsl(0, 0%, 99%);
...
background-color: var(--tab-background-normal);

It makes themming somewhat complicated, as 0, 0%, 99% doesn't get recognized by my text editor. Besides it doesn't allow to use e.g. rgb() format in --tab-background-normal.

Would you accept a PR, fixing this?

eoger commented 6 years ago

Sure

dos1 commented 6 years ago

I already noticed and wanted to change this, but turned out there are some places that use notation like hsla(var(--tab-background-normal), 75%);, so I left it as is. My CSS-fu is a bit rusty though, so maybe there's a better way to reduce opacity of a color from variable these days? :)

dos1 commented 6 years ago

It's already fixed, isn't it?

noscript commented 6 years ago

Looks like it is :)