search

eoger / tabcenter-redux

Vertical Tabs extension for Firefox
Mozilla Public License 2.0
381 stars 67 forks source link

Ctrl+scroll causes sidebar to zoom #260

Closed Keith94 closed 6 years ago

Keith94 commented 6 years ago

Steps to reproduce

  1. Hover the Tab Center Redux sidebar with the mouse.
  2. Hold Ctrl and scroll with the mouse wheel.

Info: https://stackoverflow.com/questions/27116221/prevent-zoom-cross-browser

lopis commented 6 years ago

Which OS and which Fx version? I couldn't reproduce this

Keith94 commented 6 years ago

@lopis Win 10 + Fx 59

dos1 commented 6 years ago

I can reproduce with Fx59 on GNU/Linux. I think the first time I did it accidentally was after switching from 57 beta to 59 nightly.

Lej77 commented 6 years ago

Tree Style Tabs just fixed this problem. More info at Tree Style Tab Issue 1566.

allixx commented 6 years ago

I don't know how correct this solution is, but adding this listener to tablist.js / SideTabList / setupListeners works for me:

window.addEventListener("wheel", (e) => {
    if (e.ctrlKey || ('keyCode' in e && e.keyCode == e.DOM_VK_CONTROL)) {
        e.preventDefault();
    }
});
zeroibis commented 6 years ago

Just noticed this issue, unfortunately ctrl+0 does not cause the zoom level to reset. Luckily, restarting firefox does.

Wanted to point out the issue still occurs on new installs. (maybe the fix has not been pushed public yet)