search

eoger / tabcenter-redux

Vertical Tabs extension for Firefox
Mozilla Public License 2.0
379 stars 67 forks source link

Use light variant of icon for dark themes #266

Closed Keith94 closed 5 years ago

Keith94 commented 6 years ago

The new toolbar button (a8760b1) appears too dark when using a dark theme in Firefox.

Apparently the API management.getAll() can help with determining the theme and selecting the proper icon.

dos1 commented 6 years ago

I think this API might be better suited: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/theme :)

eoger commented 6 years ago

I think what we want is checking the "dark theme" pref + browserAction.setIcon .

danbalarin commented 6 years ago

@dos1 I tried to call theme.getCurrent() and it returned me empty object with light, dark and even with custom theme. According to the API it returns theme.Theme object only for extension-supplied theme. I tried to find something to detect dark/light/custom theme, but without any success.

Keith94 commented 6 years ago

I tested the fix e0c87c4: Looks good with the dark theme, but with "Space Fantasy" theme, it looks too dull.

firefox_2018-03-29_20-10-20