search

eoger / tabcenter-redux

Vertical Tabs extension for Firefox
Mozilla Public License 2.0
381 stars 67 forks source link

icon: Honour dark/light themes #286

Closed floand closed 6 years ago

floand commented 6 years ago

This will probably solve also issue #266.

The icon appearance/definition/usage itself has been slightly changed:

Specify several icon size and theme definitions in manifest.json [2], so a correct scaled and themed extension icon can be applied in all places.

References:

eoger commented 6 years ago

It looks great. I'm a bit confused, why are you specifying multiple sizes for the same file in the .manifest file?

floand commented 6 years ago

I'm a bit confused,

So am I, ...

why are you specifying multiple sizes for the same file in the .manifest file?

normally I would not do that but then I read [1]. Unfortunately it doesn’t explain the ‘why-part’, so I can only guess that probably Firefox on devices with a Retina display expect the 2nd and doubled size definition.

I haven’t dig into [2] deeply for the reason because it’s working.

BTW: Locally I also explicitly specify "browser_style": true for the options_ui key [3] – even it defaults to true, because this avoids a logger warning (line 376 in [4]).

Also I’ve noticed two behaviours regarded to the icon. Firstly it overlaps the checkbox in menu: View > Sidebar > Tabs and secondly, a nice one, Firefox flips the sidebar-button horizontally depending on the position of the sidebar. Both should be on the to do list. ;-)

References:

-- Regards

eoger commented 6 years ago

Sorry about the delay, I'll have a look over your patch (and answer your comment) in the plane later next week.

eoger commented 6 years ago

Thank you!