eoger / tabcenter-redux

Vertical Tabs extension for Firefox
Mozilla Public License 2.0
381 stars 67 forks source link

unmaximized firefox startup bug resulted from using #tabbrowser-tabs { visibility: collapse;} in userStyle.css + alternative #287

Open thebunnyrules opened 6 years ago

thebunnyrules commented 6 years ago

Hi, I'm in gnome shell (Ubuntu 17.10) and I'd like to bring a bug to your attention that I experienced when I used the wiki recommended hack to disable the horizontal tabs:

#tabbrowser-tabs {
  visibility: collapse;
}

It's hard to say that this hack is responsible for the bug but I've isolated it as best I can. It occurs when I have no Firefox or Gnome Shell extensions installed (even Tab Center redux was disabled) and went away I soon as I took out these lines (even with all my extension re-enabled).

Bug is that Firefox is unable to stay maximized during startup. It will always start with a window the size of the quarter of the screen and them maximize. Sometimes it doesn't even maximize. Sometimes it's maximized but only a quarter of the maxed windows has content in it.

I changed the userStyle.css to the one that was recommended in: https://github.com/eoger/tabcenter-redux/issues/118

The bug is gone now. I realize that he uses the visibility: collapse function too, but maybe the fact that he added a !important after collapse did the trick. Maybe the last 6 lines did the trick. Or maybe it was a fluke and the bugs going to come back and I'm going to start drinking again. I don't know. I just thought I'd share this in the event someone else came across this bug.

#tabbrowser-tabs {
  visibility: collapse !important;
}

#sidebar-box {
  overflow-x: hidden;
  min-width: 0 !important;
  width: 5em !important;
  margin-top: -48px;
  transition: margin 0.2s ease-in-out 2s;
}

#newtab-label, #newtab  {
  display: none !important;
}

#settings {
  display: none !important;
}
thebunnyrules commented 6 years ago

Yeah... the bug's back. I guess it was fluke and I guess, I'm going to have take it up with Firefox. I've started a thread here:

https://support.mozilla.org/en-US/questions/1195529

If you are also experiencing this problem, please go and bump the post.