Open thomcc opened 6 years ago
Apologies for the very long review delay. Now that we have explicit tab positioning (https://github.com/eoger/tabcenter-redux/commit/41128b108c0b7d4a45748009ac5abd28bd289cf2), I came round and think that this is a good addition (and the patch looks great). Since I'm super late to that review, I don't except you to make the effort to re-base/update it and I'll probably do it myself when I get some time.
Such a good addition. Do you have plan to merge this?
Is there a way to help this get merged?
Most of the sidebars in the browser have focus in the search bar when they come up, so it seems like this one should too. It also helps alleviate #304, which doesn't seem doable currently (
el.focus()
when called from a command handler never seems to work. I can't tell if there's a bug on file for that yet, or if it's even a bug at all vs a design choice).The second commit is much meatier but basically just adds the notion of a currently "selected" tab to the sidebar. This allows easier navigation of search results with the arrow keys. The behavior I've used was chosen by what "feels" good, and I've added comments to explain the non-obvious parts.
Some notes, most of which are also in comments: