search

eoger / tabcenter-redux

Vertical Tabs extension for Firefox
Mozilla Public License 2.0
381 stars 67 forks source link

Refactor SideTabList to be more explicit about positioning. #315

Closed thomcc closed 6 years ago

thomcc commented 6 years ago

Right now the position is implicitly the same as the DOM. This makes a number of features harder, and makes certain things more complex and slower than they should be.

I'd like to wait for my outstanding PRs to get merged before this, however.

eoger commented 6 years ago

This is somewhat connected to https://github.com/eoger/tabcenter-redux/issues/296 since the DOM may have holes now.

eoger commented 6 years ago

Fixed by https://github.com/eoger/tabcenter-redux/commit/41128b108c0b7d4a45748009ac5abd28bd289cf2!