search

eoger / tabcenter-redux

Vertical Tabs extension for Firefox
Mozilla Public License 2.0
381 stars 67 forks source link

Dark theme colors to match Photon Dark theme #321

Closed craftycorvid closed 6 years ago

craftycorvid commented 6 years ago

Fixes #170 and #255

This makes the Tab Center dark theme match the colors of the dark theme introduced in Firefox 57+. I just focused on making the dark them as accurate as possible so hopefully this is up to standards.

Tested on Windows and macOS.

eoger commented 6 years ago

Great work! One thing I've noticed is that all tabs text is white, whereas in the native tabstrip only the active tab text is white, the rest is gray-ish. Maybe we could introduce a new --inactive-tab-text-color variable? You could also just use the --secondary-text-color variable but I assume it was too dark to be legible?

screen shot 2018-03-28 at 12 58 10 am screen shot 2018-03-28 at 12 58 15 am
craftycorvid commented 6 years ago

I'm not seeing that at all. The tab text is always white in the default tab bar. I'm currently looking at it in Windows on Firefox 60.

capture

eoger commented 6 years ago

Heh interesting, let's merge this then, we can revisit that another time, thank you!