search

eoger / tabcenter-redux

Vertical Tabs extension for Firefox
Mozilla Public License 2.0
381 stars 67 forks source link

Last update (30 April 2018) is broken #342

Closed unclechu closed 6 years ago

unclechu commented 6 years ago

After last update I just see empty black space instead of tabs list. screenshot from 2018-04-30 19-14-39 screenshot from 2018-04-30 19-15-31

unclechu commented 6 years ago

Reinstalling (removing and installing it again) haven't helped.

Smile4ever commented 6 years ago

Do you see errors in the browser console?

unclechu commented 6 years ago

Forgot to mention version of my browser: Firefox Quantum 57.0.1 (64-bit).

unclechu commented 6 years ago

@Smile4ever just on any page? Nothing specific to this plugins (on https://www.haskell.org/ for example it's empty.

eoger commented 6 years ago

Can you go to about:debugging, look for Tab Center Redux and press the Debug button (you might have to check "Enable add-on debugging" at the top of the page)? This will open the addon console. I'm guessing we're using an API that isn't supported on 57.

unclechu commented 6 years ago

@eoger here is what I see there when I open plugin's window:

[Exception... "Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIMessageSender.sendAsyncMessage]"  nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)"  location: "JS frame :: resource://gre/modules/ExtensionUtils.jsm :: sendAsyncMessage :: line 505"  data: no]  (unknown)
[Exception... "Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIMessageSender.sendAsyncMessage]"  nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)"  location: "JS frame :: resource://gre/modules/ExtensionUtils.jsm :: sendAsyncMessage :: line 505"  data: no]  (unknown)
TypeError: browser.theme.onUpdated is undefined[Learn More]  bundle.js:155:1
unclechu commented 6 years ago

And also in expanded exception's trace:

sendAsyncMessage resource://gre/modules/ExtensionUtils.jsm:505:51
_handleMessage/deferred.promise< resource://gre/modules/MessageChannel.jsm:774:9
eoger commented 6 years ago

Thank you! We should probably early return if browser.theme.onUpdated is undefined in here https://github.com/eoger/tabcenter-redux/blob/a21df79571da76860421d5eeb9d6bcc6a0f4c509/src/sidebar/tabcenter.js#L77

Alternatively if you have the possibility you should try to upgrade your Firefox. Ping @nt1m

nt1m commented 6 years ago

@unclechu I can fix this, but I do recommend you to upgrade as Firefox 57 is unsupported at this point.

eoger commented 6 years ago

Feel free to pull the code from master, I'll make a new build sometimes this week.