eoger / tabcenter-redux

Vertical Tabs extension for Firefox
Mozilla Public License 2.0
381 stars 67 forks source link

Reordering tabs via extension breaks tab hiding #347

Closed Keith94 closed 6 years ago

Keith94 commented 6 years ago

Steps to reproduce

  1. Install Simple Tab Groups (experimental) and Order Tabs by Domain
  2. Create two tab groups each containing various tabs
  3. Order tabs via domain via the toolbar button

Expected results

Hidden tabs from other groups should not appear

Actual results

Hidden tabs from other groups appear in the sidebar

Screen capture:

2018-05-13_17-10-38

Smile4ever commented 6 years ago

Seems to be caused by https://github.com/eoger/tabcenter-redux/blob/5c968e03e109c515f4ee441e9a64ab1bfb202000/src/sidebar/tablist.js#L125-L140

which does not take the "hidden" property into account.

If that's the case, it should be reproducible by these steps:

Keith94 commented 6 years ago

Nice detective work! I hope that's an easy fix.

Keith94 commented 6 years ago

@eoger Thank you for the fix