Integration with Tab Groups

[krdln]

When using tabcenter-redux with the Tab Groups addon, tabs from all the groups are visible in the sidebar. Expected behaviour is to show tabs only from current group (which is what the default tab-strip is doing).

I don't know if it's worth fixing this, as the Tab Groups addon is not an webextension anyway, so feel free to close this issue.

Alternatively, maybe minimal version of tab groups could be implemented in this addon directly?

[Dimas-sc]

I tried this extension and went back to standard Tab Group extensions just because this problem. Hope there could be a solution.

El dj., 15 juny 2017, 22:44, krdln notifications@github.com va escriure:

When using tabcenter-redux with the Tab Groups https://addons.mozilla.org/firefox/addon/tab-groups-panorama/ addon, tabs from all the groups are visible in the sidebar. Expected behaviour is to show tabs only from current group (which is what the default tab-strip is doing).

I don't know if it's worth fixing this, as the Tab Groups addon is not an webextension anyway, so feel free to close this issue.

Alternatively, maybe minimal version of tab groups could be implemented in this addon directly?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/eoger/tabcenter-redux/issues/36, or mute the thread https://github.com/notifications/unsubscribe-auth/ACTcP6C3g2cuO_JHeOq3lfzsMdL4gdlFks5sEZfAgaJpZM4N7uGm .

[omeringen]

He quits developing Tab groups extension: http://fasezero.com/lastnotice.html There is an alternative addon and they are probably going to port it to webextension in the future: https://github.com/denschub/firefox-tabgroups/issues/60 Also, there is a testpilot experiment about containers. Maybe it'll become something similar to the tab groups feature: https://github.com/mozilla/testpilot-containers/issues/336

[ghost]

This WebExtension which utilises the containers testpilot experiment seems similar to tab groups/tab center #33 https://github.com/jonathanKingston/sea-containers

[ghost]

The original spec seems to have included Tab Groups in the completed version of the addon:

https://mozilla.invisionapp.com/share/GT22ZN6QW#/screens/59200119

[grahamperrin]

Which add-on, on which version of Firefox? I'm aware of some features of some add-ons working only with 55+

[eoger]

It seems that a lot of people (outside of this channel) are requesting this. I will (NO PROMISES, ALL CAPS) try to have a look and see how much changes are required in the codebase to implement this. tl;dr: I'm not against the idea, just concerned about the implementation/maintenance cost.

[grahamperrin]

1. thanks @eoger (understatement)
2. @denschub you too, https://twitter.com/grahamperrin/status/877043008000208896 :-)
3. @eoger assuming that it's not ideal to aim for integration with Tab Center, which will not be WebExtensions-compatible, please consider changing the title of this issue to:

• integration with Simplified Tab Groups

Related: open issue https://github.com/denschub/firefox-tabgroups/issues/60 Port to WebExtension

---

My hesitance here is comparable to hesitance around the suggestion to integrate with Sea Containers.

I can not easily phrase this. If there will be integration with an add-on that has a particular set of characteristics, then:

• might that first integration complicate, or preclude, a later wish to integrate with an alternative (or complement) to Simplified Tab Groups that will have a broader – less simplified – set of characteristics?

[ghost]

^ I also use Tab Groups with a complementary extension called Tab Groups Helper which I prefer to the UI of the standard Tab Groups implementation.

But the functionality of Tab Groups Helper/Sea Containers/Simplified Tab Groups/etc should be a later (if ever) focus. Merely creating a WebExtension version of Tab Groups could be a challenge.

If Tab Center Redux can add Tab Groups into it's functionality then I'm sure other developers will create different UIs to utilise that functionality.

[eoger]

If I had to implement a tab groups feature, that would be a simplified version like the one shown in https://github.com/eoger/tabcenter-redux/issues/36#issuecomment-308969949, basically tabs for Tab Center (wow that's meta). Nothing else. I also did some thinking, I think Bug 1322060 would be required to have a solid implementation.

[grahamperrin]

… like the one shown in #36 (comment), …

If implemented, it will need:

• left and right arrows (to horizontally scroll the tabs – assume that people will have more than two groups); and then
• a rethink of the triangle that 'joins' the vertical list of tabs to the tab for the current group – for when that tab has been scrolled out of sight …

[SXZ1]

I also did some thinking, I think Bug 1322060 would be required to have a solid implementation.

You'll also need https://bugzilla.mozilla.org/show_bug.cgi?id=1325692 By default ctrl-tab changes tabs in the order they are placed on the vanilla tab bar. However, with tab groups all tabs that do not belong to the active group should be hidden. That means ctrl-tab will have to switch only between the tabs that are visible in the sidebar and that means you'll have to override built-in keyboard shortcuts.

For example: Vanilla tab bar: [tab1][tab2][tab3] Sidebar, Tab group 1 is active: [tab1][tab2 from tab group 2, hidden][tab3]

Let's imagine you press ctrl-tab 2 times, what happens: tab1 is focused, tab2 is focused, tab3 is focused What should happen: tab1 is focused, tab3 is focused, tab1 is focused.

[escapewindow]

• Aki Sasaki asasaki@mozilla.com [2017-06-22 23:59]:

  I've been looking for a solution to tab groups going away with Firefox 57. One solution appears to be using multiple windows and moving tabs between them.

  I like tab mover, but it appears it only shows the menu item if I click on the tab bar tab... clicking on the page itself doesn't show the menu item, and clicking on the tab in either the Sea Containers or Tab Center vertical tab strip doesn't show me the menu item. Do you know if it's possible to add support for at least one of those? When that happens, I can hide my top horizontal tab bar.

both addons do not show the "native" tab menu (which is not possible for webextensions) but rather reimplement it, thus any addons to the tab menu will not show up. AFAIK there is also not way for Webextensions to extend or modify each other, so I think the only solution would be to ask the authors of either addon to implement the functionality of tab-mover. Fortunately that's relatively simple, and they are welcome to incorporate tab mover code available from https://hg.guido-berhoerster.org/addons/firefox-addons/tab-mover/.

Hope that helps,

[ajvsol]

I also did some thinking, I think Bug 1322060 would be required to have a solid implementation.

This has been marked resolved for Firefox 57 by the way.

[grahamperrin]

… tab mover …

Related (Tab Mover is one of a number of bugs affected by this):

• Mozilla bug 1378459 - Allow some addon functionality to load prior to any content loading

[eoger]

Closing this for now, I have no plans to integrate this at the moment.