search

eoger / tabcenter-redux

Vertical Tabs extension for Firefox
Mozilla Public License 2.0
381 stars 67 forks source link

Pinned tab list not completely hidden when a search yields no match in pinned tabs #368

Open ariasuni opened 6 years ago

ariasuni commented 6 years ago

Only happen when «Compact Pinned Tabs» enabled.

Before search: screenshot_20180607_124202

After search: screenshot_20180607_124237

There is a small gap between the main tab list and the toolbar, that is obvious if you look at the right.

ariasuni commented 6 years ago

I located the CSS rule that is causing the issue:

https://github.com/eoger/tabcenter-redux/blob/6b3431efd1eac15bbc91a8dbce7f5b4b19df5aa9/src/sidebar/tabcenter.css#L375

When there is a pinned tab that is hidden, there’s still the 1px border.

I don’t know how to fix this properly though.