search

eolant / vuetify-toast-snackbar

Basic Vue toast service that uses Vuetify Snackbar component.
MIT License
127 stars 36 forks source link

compatible v-icon #27

Closed robin-dongbin closed 4 years ago

robin-dongbin commented 4 years ago

Use Vuetify's way.

eolant commented 4 years ago

Doesn't work for me.

robin-dongbin commented 4 years ago

You can read source code of vuetify

eolant commented 4 years ago

I did, just saying your pull request doesn't work on the demo page. Have you tested it?

robin-dongbin commented 4 years ago

Sure,It works well in my case

eolant commented 4 years ago

Link?

robin-dongbin commented 4 years ago

I only test in my local environment. There is the vuetify source code: https://github.com/vuetifyjs/vuetify/blob/f329abc3d3f267691753ab6c329070a045fde19f/packages/vuetify/src/util/helpers.ts#L325

eolant commented 4 years ago

Cool, but it will not work in the case of this library. Try it yourself, build it and include local index.umd.js in index.html if you haven't tested it properly. I'm closing this pull request and will add an option to specify close icon.