eole-nlp / eole

Open language modeling toolkit based on PyTorch
https://eole-nlp.github.io/eole
MIT License
62 stars 12 forks source link

Deduce share_decoder_embeddings from HF tie_word_embeddings flag #123

Closed francoishernandez closed 1 month ago

francoishernandez commented 1 month ago

121 was not fully functional (bad refactoring pre-merge). But in fact the complexity is not needed, we can rely on the tie_word_embeddings flag from the HF config.