Resize the key_pad_mask

eole-nlp / eole

Open language modeling toolkit based on PyTorch

https://eole-nlp.github.io/eole

MIT License

53 stars 11 forks source link

Closed l-k-11235 closed 3 months ago

l-k-11235 commented 3 months ago

This PR resizes properly the key_pad_mask. I retrieve the same outputs as before the last commits with this small patch.

l-k-11235 commented 3 months ago

@francoishernandez, you mentioned in #29 that it might not cover all cases. Do you have anything specific in mind? Should we still merge this PR?

francoishernandez commented 3 months ago

No specific case in mind, we just need to keep in mind that issues might remain in such codepaths since test coverage is still not sufficient.