search

eole-nlp / eole

Open language modeling toolkit based on PyTorch
https://eole-nlp.github.io/eole
MIT License
46 stars 9 forks source link

Send src_pad_mask and tgt_pad_mask to decoder in _align_forward #96

Closed dameikle closed 1 week ago

dameikle commented 1 week ago

Fixes assertion error when using _--reportalign by passing _src_padmask and _tgt_padmask to decoder

  File "~/eole/eole/decoders/transformer_decoder.py", line 180, in forward
    assert tgt_pad_mask is not None, "TransformerDecoder requires a tgt pad mask"
AssertionError: TransformerDecoder requires a tgt pad mask
vince62s commented 1 week ago

LGTM did you check it's working fine?

dameikle commented 1 week ago

Yes, made the change so I could test access the alignments on a model I had been training.