search

eoly / puppet-rancid

Rancid Puppet Module
Other
6 stars 29 forks source link

Allow the hiding of diffs of cloginrc #14

Closed r4v5 closed 9 years ago

r4v5 commented 9 years ago

Some people put passwords into cloginrc. This PR adds the facility to hide diffs of that particular file for those people.

r4v5 commented 9 years ago

Apparently this would cost you 3.1.0 compatibility.

ghoneycutt commented 9 years ago

Looks like show_diff was added in v3.6.0.. how odd.

r4v5 commented 9 years ago

show_diff as a file param seems to exist as far back as 3.2.1: https://docs.puppetlabs.com/references/3.2.1/type.html#file but wasn't there in 3.1.

This would be a breaking change for whoever is still using 3.1 out there.

ghoneycutt commented 9 years ago

+1

Given this module is pre 1.0.0

eoly commented 9 years ago

Merged #15 which covers the changes here.