search

eonpatapon / gnome-shell-extension-caffeine

Disable screensaver and auto suspend
GNU General Public License v2.0
588 stars 108 forks source link

Symbolic icon doesn't quite respect shell light style #308

Closed not-a-dev-stein closed 1 year ago

not-a-dev-stein commented 1 year ago

A small change in GNOME 45 that almost went unnoticed due to not being exposed outside of gsettings yet is the shell light style. One can use it by enabling it through gsettings or by using the Light Style extension, and when you are using it, the caffeine icon doesn't quite work with it. An example of how it looks follows:

image

See how the cup icon works well but the "vapor" part of the icon doesn't recolor? That's the thing. It's not a major issue, but it's something that bugs me and that should probably be fixed before GNOME 46, where it'll likely be exposed in the settings.

stuarthayhurst commented 1 year ago

Thanks for catching this, can you test #309 please?

not-a-dev-stein commented 1 year ago

Oh shoot, didn't catch that open MR, it works great!

stuarthayhurst commented 1 year ago

Oh shoot, didn't catch that open MR, it works great!

Glad it works! You didn't miss it, I submitted it in response to this report :)

not-a-dev-stein commented 1 year ago

Oh shoot, didn't catch that open MR, it works great!

Glad it works! You didn't miss it, I submitted it in response to this report :)

Wow, thanks for the quick work!