search

eonpatapon / mpDris2

MPRIS V2.1 support for mpd
GNU General Public License v3.0
210 stars 46 forks source link

Add option to disable notification at startup #109

Closed AndreaOrru closed 5 years ago

AndreaOrru commented 5 years ago

Added a notify_startup option to the configuration file (defaults to True).

eonpatapon commented 5 years ago

This startup notification is for detecting if some service provides org.freedesktop.Notification.

Is it disturbing for you?

grawity commented 5 years ago

This startup notification is for detecting if some service provides org.freedesktop.Notification.

Hmm, that could be done quietly using GetNameOwner() instead.

(If you want to check whether there's an activatable service that provides o.f.Notifications, there are ListActivatableNames() or StartServiceByName(), but it's probably not a good idea to rely on auto-activation for such "multiple provider" names in the first place.)

eonpatapon commented 5 years ago

@grawity I will try to use GetNameOwner() instead then

AndreaOrru commented 5 years ago

This startup notification is for detecting if some service provides org.freedesktop.Notification.

Is it disturbing for you?

Not massively, but I would prefer not to have it :) Feel free to close this PR if the other one addresses the problem.

Thank you!

eonpatapon commented 5 years ago

Thanks, other PR is merged