search

eonpatapon / mpDris2

MPRIS V2.1 support for mpd
GNU General Public License v3.0
210 stars 46 forks source link

mpd connection should be read from environment, not hardcoded localhost #93

Closed tidux closed 6 years ago

tidux commented 6 years ago

The MPD_HOST environment variable exists so client programs like mpDris2 can connect to daemons running on something other than localhost:6600. I have some systems where mpd is bound to a specific non-localhost IPv4 or IPv6 address in order to enable network control, and mpDris2 can't connect to these systems without manually editing the script. This is suboptimal.

grawity commented 6 years ago

Reading MPD_HOST from environment (and config file, and command line) has been supported since 2011:

https://github.com/eonpatapon/mpDris2/blob/c8a764a006d5c9462879e7cff86ecd90cd8d5c19/mpDris2#L583-L594