search

eonu / sequentia

Scikit-Learn compatible HMM and DTW based sequence machine learning algorithms in Python.
https://pypi.org/project/sequentia/
MIT License
63 stars 8 forks source link

Incorrect implementation of `predict_log_proba` for `KNNClassifier` #246

Closed eonu closed 7 months ago

eonu commented 7 months ago

Has this already been reported?

Expected behaviour

Should be predict_proba not predict_scores.

Observed behaviour

https://github.com/eonu/sequentia/blob/b1aeb609996b5148ddd0913abc610976bed7f464/sequentia/models/knn/classifier.py#L300

Code to reproduce

N/A

Version details

N/A
eonu commented 7 months ago

Fixed in #247.