search

eoscanada / eos-go

EOS.IO Go API library
MIT License
561 stars 217 forks source link

Fix NewPrivateKey correctly working with PVT_K1 keys #177

Closed maxifom closed 2 years ago

maxifom commented 2 years ago

Fix NewPrivateKey correctly working with PVT_K1 keys. Added test for PVT_K1 NewPrivateKey.

maoueh commented 2 years ago

@maxifom Hey thanks! Can you fix the failing tests, I think it's simply because the old test is now wrong with the change you added and can you add a note in the https://github.com/eoscanada/eos-go/blob/develop/CHANGELOG.md file please.

I'll merge after that.

maxifom commented 2 years ago

@maoueh Should I create 0.10.3 in the Changelod?

maoueh commented 2 years ago

Add something under Unreleased section in Fixed sub-section.

maoueh commented 2 years ago

Do you want me to release a new version once this is merged?

maxifom commented 2 years ago

It would be nice, because it will allow eos.KeyBag to Import keys with PVT_K1, but I personally don't use eos-go, I am just using it as the reference to create transaction encoder to allow me to code generate type-safe actions from ABI.

maxifom commented 2 years ago

Added changelog.

maxifom commented 2 years ago

@maoueh