search

eoscanada / network-discovery

EOS Network Discovery Files for EOS Canada
https://www.eoscanada.com
9 stars 5 forks source link

Define host & port separately #1

Open DenisCarriere opened 6 years ago

DenisCarriere commented 6 years ago

I would suggest we define host & port separately, that way you don't have to parse the URL to break down these two fields.

When using cleos, you need to define --host & --port params, if we combine both host & port together one would need to split the URL to extract those details and possibly assume port 443/80.

Now

eosio_http: http://example.com:8888
eosio_https: https://example.com

Propose

eosio_http_host: example.com
eosio_http_port: 8888
eosio_https_host: example.com
eosio_https_port: 443
DenisCarriere commented 6 years ago

Note: When using cleos net connect it requires hostname:port

Maybe we should also define both host & port for p2p?

eosio_p2p_host: example.com
eosio_p2p_port: 9876