search

eosdac / eosdactoolkit

DEPRECATED The DAC toolkit for building and running DACs
MIT License
10 stars 13 forks source link

some fixes #178

Closed piecesnbits closed 5 years ago

lukestokes commented 5 years ago

I just created a new dev branch based on today's dev call conversation. Could you go ahead and recreate this pull request to go to dev instead? That way we only push into master when it's ready for production and has all the language strings in place and such. The PR from dev to master can be reviewed more closely as well.

We got rid of the dev branch thinking project branches would work out, but it seems with outside PRs, a dev branch people can work with makes sense, though we will have to remember to merge master back in to dev on a regular basis or make dev the default branch for everything we want to add such as language string changes and such.

lukestokes commented 5 years ago

Are these changes covered in https://github.com/eosdac/eosdactoolkit/pull/179 ? If so, mind if I close this one? Thanks.

lukestokes commented 5 years ago

Closing PR as these changes are in dev now.