Our engineering team standard of requiring two approvals for any PR is good to have, but we need more clarity about who all is eligible to perform those approvals. We may wish to consider conditional roles for some contributors if they are the owner of a given feature set. One recent example would be to consider allowing Peter to be one of two reviewers to PRs related to performance harness since he has been technical lead on that project. A simple matrix of who is an eligible approver for what would make the review process go smoother in the future.
Our engineering team standard of requiring two approvals for any PR is good to have, but we need more clarity about who all is eligible to perform those approvals. We may wish to consider conditional roles for some contributors if they are the owner of a given feature set. One recent example would be to consider allowing Peter to be one of two reviewers to PRs related to performance harness since he has been technical lead on that project. A simple matrix of who is an eligible approver for what would make the review process go smoother in the future.